From 22e7a6c85a8614d09e511af94c410a4c29bfc8af Mon Sep 17 00:00:00 2001 From: Jean Gatto Date: Fri, 25 Apr 2025 13:42:58 -0300 Subject: [PATCH] refactor(ApiResponse): change generic type parameter from T to TResult for clarity --- src/Shop.PublicApi/Models/ApiResponseT.cs | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/Shop.PublicApi/Models/ApiResponseT.cs b/src/Shop.PublicApi/Models/ApiResponseT.cs index 8fbb9bc..d943fb6 100644 --- a/src/Shop.PublicApi/Models/ApiResponseT.cs +++ b/src/Shop.PublicApi/Models/ApiResponseT.cs @@ -4,11 +4,15 @@ using Microsoft.AspNetCore.Http; namespace Shop.PublicApi.Models; -public sealed class ApiResponse : ApiResponse +public sealed class ApiResponse : ApiResponse { [JsonConstructor] - public ApiResponse(T result, bool success, string successMessage, int statusCode, IEnumerable errors) - : base(success, successMessage, statusCode, errors) + public ApiResponse( + TResult result, + bool success, + string successMessage, + int statusCode, + IEnumerable errors) : base(success, successMessage, statusCode, errors) { Result = result; } @@ -17,14 +21,14 @@ public sealed class ApiResponse : ApiResponse { } - public T Result { get; private init; } + public TResult Result { get; private init; } - public static ApiResponse Ok(T result) => + public static ApiResponse Ok(TResult result) => new() { Success = true, StatusCode = StatusCodes.Status200OK, Result = result }; - public static ApiResponse Ok(T result, string successMessage) => + public static ApiResponse Ok(TResult result, string successMessage) => new() { Success = true, StatusCode = StatusCodes.Status200OK, Result = result, SuccessMessage = successMessage }; - public static ApiResponse Created(T result) => + public static ApiResponse Created(TResult result) => new() { Success = true, StatusCode = StatusCodes.Status201Created, Result = result }; } \ No newline at end of file