Avoid processing packages in parallel in ValidateApiDiff (#19511)

2025-08-22 15:56:42 +02:00
parent da52b7246f
commit 0225edd8c0
1 changed files with 6 additions and 13 deletions
@@ -47,20 +47,13 @@ public static class ApiDiffHelper

        var allErrors = new List<string>();

-        Parallel.ForEach(
-            packageDiff.Frameworks,
-            framework =>
-            {
-                var args = $""" -l="{framework.BaselineFolderPath}" -r="{framework.CurrentFolderPath}" {suppressionArgs}""";
+        foreach (var framework in packageDiff.Frameworks)
+        {
+            var args = $""" -l="{framework.BaselineFolderPath}" -r="{framework.CurrentFolderPath}" {suppressionArgs}""";

-                var localErrors = GetErrors(apiCompatTool(args));
-
-                if (localErrors.Length > 0)
-                {
-                    lock (allErrors)
-                        allErrors.AddRange(localErrors);
-                }
-            });
+            var localErrors = GetErrors(apiCompatTool(args));
+            allErrors.AddRange(localErrors);
+        }

        ThrowOnErrors(allErrors, packageDiff.PackageId, "ValidateApiDiff");
    }